Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python2 logic. #985

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

acolwell
Copy link
Collaborator

@acolwell acolwell commented Jul 22, 2024

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

  • Removes #ifdefs related to Python 2 builds since we won't be supporting Python 2 going forward.
  • Removed PyInt_xx function calls since they don't exist in Python 3 and were being mapped to the PyLong_ equivalents by shiboken.h/sbkpython.h.

Have you tested your changes (if applicable)? If so, how?

Yes. The installer builds and passes all tests.

Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolwell acolwell merged commit 7683518 into NatronGitHub:RB-2.6 Jul 23, 2024
3 checks passed
@acolwell acolwell deleted the remove_python2_code branch July 23, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants